Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wizard): add back inline wizards in 16.x #1068

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

kevinbuhmann
Copy link
Member

This is a port of c5d3f09 (#1067) to 16.x.

This reverts commit 7470769 (#419), removes the deprecated comments, and adds a comment explaining when inline wizards are used.

Inline wizards are used by vSphere plugins to display a wizard inside an iframe that is inside a modal.

CDE-154

This is a port of c5d3f09 (#1067) to 16.x.

This reverts commit 7470769 (#419),
removes the deprecated comments, and adds a comment explaining when
inline wizards are used.

Inline wizards are used by vSphere plugins to display a wizard inside an iframe
that is inside a modal.

CDE-154
@kevinbuhmann kevinbuhmann requested a review from a team November 17, 2023 01:00
@kevinbuhmann kevinbuhmann self-assigned this Nov 17, 2023
Copy link
Contributor

github-actions bot commented Nov 17, 2023

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann merged commit 8a623cb into main Nov 21, 2023
5 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/inline-wizard-16.x branch November 21, 2023 02:54
Copy link
Contributor

🎉 This PR is included in version 16.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants