This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Track controller-runtime 0.15 development #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
- Coverage 59.74% 57.94% -1.81%
==========================================
Files 16 14 -2
Lines 2124 1964 -160
==========================================
- Hits 1269 1138 -131
+ Misses 773 748 -25
+ Partials 82 78 -4
☔ View full report in Codecov by Sentry. |
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
An upstream change in the fake client now distinguishes between patch/update requests to resource with a status sub-resource and those without. Requests made to a resource with the status sub-resource at the main resource are not able to mutate the status, and requests made to the status sub-resource are only able to modify the status. Requests using the status sub-resource to types that have not indicated they support the status sub-resource will return a not found error. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.