Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Update original cast resource even on reconciliation error #474

Merged

Conversation

LittleBaiBai
Copy link
Contributor

Closes #473

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (662509e) 60.67% compared to head (8a49026) 60.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   60.67%   60.87%   +0.20%     
==========================================
  Files          26       26              
  Lines        2543     2546       +3     
==========================================
+ Hits         1543     1550       +7     
+ Misses        911      909       -2     
+ Partials       89       87       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LittleBaiBai LittleBaiBai force-pushed the bella/cast-resource-update-on-error branch from 400b6d1 to 8a49026 Compare January 24, 2024 02:10
Copy link
Collaborator

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this issue, @LittleBaiBai!

@mamachanko mamachanko merged commit 21b0161 into vmware-labs:main Jan 24, 2024
3 checks passed
@LittleBaiBai LittleBaiBai deleted the bella/cast-resource-update-on-error branch January 24, 2024 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CastResource does not keep its status update on error
3 participants