Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump gomplate from v3.11.2 to v3.11.3 #380

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

aseques
Copy link
Contributor

@aseques aseques commented Nov 23, 2022

Summary of Pull Request

It seems that there was and advisory related to a dependency and they upped the version https://github.com/hairyhenderson/gomplate/releases/tag/v3.11.3

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

It seems that there was and advisory related to a dependency and they upped the version https://github.com/hairyhenderson/gomplate/releases/tag/v3.11.3
@aseques aseques requested a review from a team as a code owner November 23, 2022 12:08
@tenthirtyam tenthirtyam changed the title Gomplate version recommended is v3.11.3 chore(deps): bump gomplate from v3.11.2 to v3.11.3 Nov 23, 2022
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

I’ve updated the pull request to follow conventional commit structure.

@tenthirtyam tenthirtyam merged commit af14267 into vmware-samples:main Nov 23, 2022
tenthirtyam added a commit that referenced this pull request Nov 23, 2022
@tenthirtyam
Copy link
Contributor

I just noticed after merge there is a missed reference in the README.md. I’ll update it before next release.

@tenthirtyam tenthirtyam added type/chore Chore area/dependencies Area: Dependencies labels Nov 23, 2022
@tenthirtyam tenthirtyam added this to the v22.11 milestone Nov 23, 2022
tenthirtyam added a commit that referenced this pull request Nov 29, 2022
Update `README.md` for Gomplate version v3.11.3 update missed in #380.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Nov 29, 2022
Update `README.md` for Gomplate version v3.11.3 update missed in #380.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependencies Area: Dependencies type/chore Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants