Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug of omitted registry case #85

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

JingChen23
Copy link
Contributor

Signed-off-by: Chen Jing jingch@vmware.com

Fix issue #84

Test: The new UT passed.

Signed-off-by: Chen Jing <jingch@vmware.com>
Signed-off-by: Chen Jing <jingch@vmware.com>
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@cf40e49). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage        ?   42.04%           
=======================================
  Files           ?        6           
  Lines           ?      892           
  Branches        ?        0           
=======================================
  Hits            ?      375           
  Misses          ?      487           
  Partials        ?       30           
Flag Coverage Δ
unittests 42.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@qijianshuai qijianshuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qijianshuai qijianshuai merged commit cbed43a into vmware-tanzu:main Dec 14, 2022
@JingChen23 JingChen23 deleted the fix-omitted-registry branch March 7, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants