This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
VSphereCPI exposes node IP exclude CIDRs #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
adobley
force-pushed
the
expose-vsphere-cpi-exclude-ips
branch
from
549d0ea
to
e1bf276
Compare
christianang
force-pushed
the
expose-vsphere-cpi-exclude-ips
branch
2 times, most recently
from
f225026
to
9b9f193
Compare
lubronzhan
reviewed
Jan 12, 2022
addons/packages/vsphere-cpi/1.23.0-alpha.1/test/vsphere_cpi_test.go
Outdated
Show resolved
Hide resolved
lubronzhan
previously approved these changes
Jan 12, 2022
VSphereCPI can be configured to not assign Node IPs from configured CIDRs Backfill template unit tests for neighboring configuration vars Signed-off-by: Aidan Obley <aobley@vmware.com> Co-authored-by: Tyler Schultz <tschultz@vmware.com> Co-authored-by: Christian Ang <angc@vmware.com>
christianang
force-pushed
the
expose-vsphere-cpi-exclude-ips
branch
from
9b9f193
to
4c2a9c6
Compare
lubronzhan
approved these changes
Jan 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Exposes a feature of VSphereCPI to exclude Node IPs from configured CIDRs
Details for the Release Notes (PLEASE PROVIDE)
Describe testing done for PR
The code changes have been tested upstream.
We added template tests to cover the different configuration cases.
Special notes for your reviewer
This is in draft while we await the release of a cloud-provider-vsphere with our changes. When that is available we will update the go.mod and vendir in the new version.