This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
Add manifests for vsphere paravirtual CPI. #2834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
Work executed by a package's maintainer
label
Jan 12, 2022
HanFa
force-pushed
the
topic/fhan/add-vsphere-paravirtual-cpi
branch
8 times, most recently
from
January 13, 2022 06:58
4b51fb2
to
77da6d1
Compare
@blc1996 @vijaykatam PTAL |
blc1996
reviewed
Jan 14, 2022
addons/packages/vsphere-cpi/1.23.0-alpha.1/bundle/config/values.yaml
Outdated
Show resolved
Hide resolved
HanFa
force-pushed
the
topic/fhan/add-vsphere-paravirtual-cpi
branch
from
January 18, 2022 18:42
77da6d1
to
ad89ef4
Compare
github-actions
bot
added
the
owner/docs
Work executed by VMware documentation team
label
Jan 18, 2022
HanFa
force-pushed
the
topic/fhan/add-vsphere-paravirtual-cpi
branch
2 times, most recently
from
January 18, 2022 18:59
e3b0895
to
b67c96b
Compare
thanks @blc1996
Could you PTAL? |
lubronzhan
reviewed
Jan 18, 2022
...vsphere-cpi/1.23.0-alpha.1/bundle/config/upstream/vsphere-paravirtual-cpi/03-deployment.yaml
Show resolved
Hide resolved
...vsphere-cpi/1.23.0-alpha.1/bundle/config/upstream/vsphere-paravirtual-cpi/03-deployment.yaml
Outdated
Show resolved
Hide resolved
HanFa
force-pushed
the
topic/fhan/add-vsphere-paravirtual-cpi
branch
from
January 18, 2022 21:42
b67c96b
to
065c661
Compare
lubronzhan
reviewed
Jan 18, 2022
lubronzhan
reviewed
Jan 18, 2022
lubronzhan
reviewed
Jan 18, 2022
addons/packages/vsphere-cpi/1.23.0-alpha.1/bundle/config/values.star
Outdated
Show resolved
Hide resolved
lubronzhan
reviewed
Jan 18, 2022
addons/packages/vsphere-cpi/1.23.0-alpha.1/bundle/config/values.yaml
Outdated
Show resolved
Hide resolved
lubronzhan
reviewed
Jan 18, 2022
addons/packages/vsphere-cpi/1.23.0-alpha.1/test/vsphere_cpi_test.go
Outdated
Show resolved
Hide resolved
HanFa
force-pushed
the
topic/fhan/add-vsphere-paravirtual-cpi
branch
2 times, most recently
from
January 19, 2022 00:35
90a372b
to
2dd8a04
Compare
HanFa
force-pushed
the
topic/fhan/add-vsphere-paravirtual-cpi
branch
from
January 19, 2022 00:57
2dd8a04
to
ed64566
Compare
lubronzhan
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-not-required
owner/docs
Work executed by VMware documentation team
owner/packages
Work executed by a package's maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #
Describe testing done for PR
Added four unit tests for paravirtual CPI objects.
Special notes for your reviewer