Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Add manifests for vsphere paravirtual CPI. #2834

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add manifests for vsphere paravirtual CPI. #2834

merged 1 commit into from
Jan 19, 2022

Conversation

HanFa
Copy link
Contributor

@HanFa HanFa commented Jan 12, 2022 •
edited
Loading

What this PR does / why we need it

Details for the Release Notes (PLEASE PROVIDE)

Add manifests for vsphere paravirtual CPI with unit test.

Which issue(s) this PR fixes

Fixes: #

Describe testing done for PR

Added four unit tests for paravirtual CPI objects.

Special notes for your reviewer

@github-actions github-actions bot added the owner/packages Work executed by a package's maintainer label Jan 12, 2022
@HanFa HanFa force-pushed the topic/fhan/add-vsphere-paravirtual-cpi branch 8 times, most recently from 4b51fb2 to 77da6d1 Compare January 13, 2022 06:58
@HanFa HanFa requested a review from lubronzhan January 13, 2022 07:01
@HanFa HanFa marked this pull request as ready for review January 13, 2022 07:01
@HanFa HanFa requested a review from a team as a code owner January 13, 2022 07:01
@shyaamsn
Copy link
Contributor

@blc1996 @vijaykatam PTAL

@HanFa HanFa force-pushed the topic/fhan/add-vsphere-paravirtual-cpi branch from 77da6d1 to ad89ef4 Compare January 18, 2022 18:42
@github-actions github-actions bot added the owner/docs Work executed by VMware documentation team label Jan 18, 2022
@HanFa HanFa force-pushed the topic/fhan/add-vsphere-paravirtual-cpi branch 2 times, most recently from e3b0895 to b67c96b Compare January 18, 2022 18:59
@HanFa HanFa requested a review from blc1996 January 18, 2022 19:03
@HanFa
Copy link
Contributor Author

HanFa commented Jan 18, 2022

thanks @blc1996
I have made some changes to address your comments. Including

update readme for new fields
add field validation in values.star
change default values to empty or something generic

Could you PTAL?

@HanFa HanFa force-pushed the topic/fhan/add-vsphere-paravirtual-cpi branch from b67c96b to 065c661 Compare January 18, 2022 21:42
@HanFa HanFa force-pushed the topic/fhan/add-vsphere-paravirtual-cpi branch 2 times, most recently from 90a372b to 2dd8a04 Compare January 19, 2022 00:35
@HanFa HanFa requested a review from lubronzhan January 19, 2022 00:36
@HanFa HanFa force-pushed the topic/fhan/add-vsphere-paravirtual-cpi branch from 2dd8a04 to ed64566 Compare January 19, 2022 00:57
lubronzhan
lubronzhan approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@lubronzhan lubronzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HanFa HanFa merged commit db51111 into main Jan 19, 2022
@stmcginnis stmcginnis deleted the topic/fhan/add-vsphere-paravirtual-cpi branch January 20, 2022 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lubronzhan lubronzhan lubronzhan approved these changes

@vijaykatam vijaykatam Awaiting requested review from vijaykatam

@blc1996 blc1996 Awaiting requested review from blc1996

Assignees
No one assigned
Labels
cla-not-required owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HanFa @shyaamsn @lubronzhan @blc1996 @vmwclabot