Remove invocation with "kubernetes" in the help #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Today plugins created with TargetK8s target type have their commands visible/invocable via both
tanzu <pluginname> ...
andtanzu kubernetes|k8s <plugingname> ...
The form without a target prefix is available only to kubernetes target for historical and compatibility reasons, but is the predominant invocation style. Since Tanzu Platform's plugin functionality are delivered through a mix of kubernetes-targeted and nonkubernetes-targeted plugins, encouraging this more compact form is important in promoting consistent and intuitive invocation styles.
This PR removes the invocation using the
kubernetes
target from the help output of plugins.Note that a plugin must be recompiled with this PR for the change to take effect. Therefore it will only start taking effect as new versions of plugins get released.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Note that I'm using the CLI build with vmware-tanzu/tanzu-cli#781 which adds a deprecation message for the invocation with the
kubernetes
target prefix.Before the change this was the output of the help for the
services
plugin which has a target ofkubernetes
:After recompiling the plugin using a plugin-runtime with this PR, the help no longer shows the invocation with
kubernetes
:Release note
Additional information
Special notes for your reviewer