Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Add empty checks for config APIs #57

Merged
merged 1 commit into from
May 4, 2023
Merged

Bug Fix: Add empty checks for config APIs #57

merged 1 commit into from
May 4, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Apr 24, 2023 •
edited
Loading

What this PR does / why we need it

  • Without these empty checks the config items like contexts, servers etc duplicate in config files when name is empty
  • Added empty value checks for config APIs to return error when encounter an empty value.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Added Unit tests
Updated the Integration tests
Cross-version compatibility tests passed

Release note

added empty checks for config apis. Config APIs now doesn't allow bad data to persist in the config yaml files

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya force-pushed the fix_empty_name_config branch 5 times, most recently from 2fb3078 to a4e0223 Compare April 27, 2023 04:02
@mpanchajanya mpanchajanya marked this pull request as ready for review April 28, 2023 18:23
@mpanchajanya mpanchajanya requested a review from a team as a code owner April 28, 2023 18:23
anujc25
anujc25 approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mpanchajanya mpanchajanya merged commit 7047da2 into vmware-tanzu:main May 4, 2023
vuil pushed a commit that referenced this pull request May 16, 2023
@mpanchajanya @vuil
Add empty value check for config items (#57)
e8c3332
@marckhouzam marckhouzam added this to the v0.90.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anujc25 anujc25 anujc25 approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
v0.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mpanchajanya @anujc25 @marckhouzam @vmwclabot