-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add null pointer check for vs #5439
Conversation
2a81c49
to
1b52e3e
Compare
Change looks good but while you are modifying the function, the log line at https://github.com/vmware-tanzu/velero/blob/main/pkg/controller/backup_controller.go#L997 seems incorrect.
The following line actually deletes the volume snapshot, not volume snapshot content. Perhaps the message can be fixed in this PR? |
Ok,I will update the code. |
1b52e3e
to
e188c56
Compare
@cleverhu Can you please resolve the conflicts? Can the PR be merged once conflicts are resolved? We are seeing the same crash reported from our users as well (cloudcasa.io). |
Ok,I will do it.Thanks |
#5388 |
e188c56
to
e90246b
Compare
It seems better, the pr fix a comment for it. |
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
e90246b
to
1620ee0
Compare
- Corresponding to PR: vmware-tanzu#5439
Since #5388 is merged, close this one for now. Feel free to reopen to address things not covered. |
Thank you for contributing to Velero!
Please add a summary of your change
Add null pointer check for vs.
Does your change fix a particular issue?
Fixes #5438
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.