Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRD descriptions for SnapshotVolumes and restorePVs #5807

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

shubham-pampattiwar
Copy link
Collaborator

@shubham-pampattiwar shubham-pampattiwar commented Jan 31, 2023

Signed-off-by: Shubham Pampattiwar spampatt@redhat.com

Thank you for contributing to Velero!

Updates the CRDs description pertaining to SnapshotVolumes and restorePVs

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #5807 (428415c) into main (358e3b8) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5807      +/-   ##
==========================================
- Coverage   40.62%   40.60%   -0.03%     
==========================================
  Files         244      244              
  Lines       21255    21255              
==========================================
- Hits         8635     8630       -5     
- Misses      11996    12001       +5     
  Partials      624      624              
Impacted Files Coverage Δ
pkg/uploader/provider/kopia.go 52.84% <0.00%> (-4.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blackpiglet
Copy link
Contributor

@shubham-pampattiwar
Hi, just to confirm with you, is the purpose of removing cloud-provider-related information from documents that some of the Velero plug-ins can also work with on-premise environments?

@shubham-pampattiwar
Copy link
Collaborator Author

@blackpiglet I made this PR with respect to the recent changes that were merged (vmware-tanzu/velero-plugin-for-csi#127) in velero-plugin-for-csi where we we are using snapshotvolumes and restorePVs for csi volumes as well and not just cloud provider ones.

@sseago sseago merged commit 53f3d13 into vmware-tanzu:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants