Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usestdlibvars and whitespace linters issues. #6162

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

blackpiglet
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Enable more linters for Velero.
This PR enable linter usestdlibvars and whitespace. All issues are fixed for the two new linters too.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #6162 (2e44227) into main (14f31ee) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6162      +/-   ##
==========================================
- Coverage   41.29%   41.27%   -0.02%     
==========================================
  Files         251      251              
  Lines       23402    23379      -23     
==========================================
- Hits         9664     9650      -14     
+ Misses      12980    12970      -10     
- Partials      758      759       +1     
Impacted Files Coverage Δ
internal/delete/delete_item_action_handler.go 74.66% <ø> (+0.98%) ⬆️
internal/hook/item_hook_handler.go 87.38% <ø> (+0.26%) ⬆️
internal/resourcepolicies/volume_resources.go 88.79% <ø> (ø)
...nal/resourcepolicies/volume_resources_validator.go 100.00% <ø> (ø)
pkg/backup/backup.go 52.24% <ø> (+0.10%) ⬆️
pkg/backup/item_backupper.go 73.62% <ø> (ø)
pkg/backup/item_collector.go 56.74% <ø> (+0.15%) ⬆️
pkg/backup/remap_crd_version_action.go 72.63% <ø> (ø)
pkg/client/config.go 19.04% <ø> (ø)
pkg/cmd/cli/backup/describe.go 0.00% <ø> (ø)
... and 15 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ywk253100 ywk253100 merged commit 1fd28e8 into vmware-tanzu:main Apr 24, 2023
@blackpiglet blackpiglet mentioned this pull request Apr 25, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants