Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRD name to error message when it is not ready to use #7295

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

josemarevalo
Copy link

@josemarevalo josemarevalo commented Jan 10, 2024

Please add a summary of your change

When debugging this error it is currently hard to identify what CRD is causing the issue. This is particularly difficult when dealing with over a hundred CRDs.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

When debugging this error it is currently hard to identify what
CRD is causing the issue. This is particularly difficult when
dealing with over a hundred CRDs.

Signed-off-by: Jose Arevalo <jose.matias.arevalo@gmail.com>
@josemarevalo josemarevalo changed the title Add CRD name to error message Add CRD name to error message when it is not ready to use Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e65ef28) 61.76% compared to head (0b307ca) 61.76%.
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/restore/restore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7295   +/-   ##
=======================================
  Coverage   61.76%   61.76%           
=======================================
  Files         262      262           
  Lines       28440    28440           
=======================================
  Hits        17567    17567           
  Misses       9642     9642           
  Partials     1231     1231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100 ywk253100 merged commit e498ea9 into vmware-tanzu:main Jan 12, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants