Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Make "disable-informer-cache" option false(enabled) by default to keep it consistent with the help message #7298

Merged

Conversation

ywk253100
Copy link
Contributor

Make "disable-informer-cache" option false(enabled) by default to keep it consi stent with the help message

Fixes #7264

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@ywk253100
Copy link
Contributor Author

Don't merge it until v1.12.3 is released

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50a1221) 60.58% compared to head (1cc6f74) 60.60%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #7298      +/-   ##
================================================
+ Coverage         60.58%   60.60%   +0.02%     
================================================
  Files               251      251              
  Lines             26791    26791              
================================================
+ Hits              16230    16238       +8     
+ Misses             9408     9401       -7     
+ Partials           1153     1152       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ywk253100
Copy link
Contributor Author

The PR is ready to review as v1.12.3 is released

…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
@reasonerjt reasonerjt merged commit cd9b5ed into vmware-tanzu:release-1.12 Jan 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants