Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the finalization phase to the restore workflow #7377

Merged

Conversation

allenxu404
Copy link
Contributor

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7183

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 66.07143% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 61.65%. Comparing base (e727d29) to head (2b8bb87).

Files Patch % Lines
pkg/controller/restore_finalizer_controller.go 68.50% 31 Missing and 9 partials ⚠️
pkg/cmd/server/server.go 0.00% 12 Missing ⚠️
pkg/persistence/object_store.go 81.25% 2 Missing and 1 partial ⚠️
pkg/controller/restore_operations_controller.go 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7377      +/-   ##
==========================================
+ Coverage   61.64%   61.65%   +0.01%     
==========================================
  Files         262      263       +1     
  Lines       28480    28627     +147     
==========================================
+ Hits        17556    17650      +94     
- Misses       9691     9734      +43     
- Partials     1233     1243      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenxu404 allenxu404 force-pushed the restore-finalization-implementation branch 2 times, most recently from 3ce2b63 to dd012b0 Compare February 2, 2024 09:15
@allenxu404 allenxu404 force-pushed the restore-finalization-implementation branch 2 times, most recently from a4c25b0 to 834aa39 Compare February 5, 2024 09:40
@allenxu404 allenxu404 marked this pull request as ready for review February 5, 2024 09:55
@allenxu404
Copy link
Contributor Author

allenxu404 commented Feb 28, 2024

@sseago Can I get a review from you when you have chance?

Signed-off-by: allenxu404 <qix2@vmware.com>
@allenxu404 allenxu404 force-pushed the restore-finalization-implementation branch from 834aa39 to 2b8bb87 Compare February 29, 2024 05:54
@reasonerjt reasonerjt merged commit edd0d3b into vmware-tanzu:main Feb 29, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add finalizing status and controller to restore workflow
3 participants