Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether the VolumeSnapshot's source PVC is nil before using it #7515

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Mar 13, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Two changes are involved in this PR:

Does your change fix a particular issue?

Fixes #7494

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
@blackpiglet blackpiglet changed the title 7494 fix Check whether the VolumeSnapshot's source PVC is nil before using it Mar 13, 2024
@blackpiglet blackpiglet self-assigned this Mar 13, 2024
Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 61.62%. Comparing base (79e9e31) to head (f8deea1).

Files Patch % Lines
internal/volume/volumes_information.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7515      +/-   ##
==========================================
- Coverage   61.62%   61.62%   -0.01%     
==========================================
  Files         263      263              
  Lines       28681    28688       +7     
==========================================
+ Hits        17675    17678       +3     
- Misses       9758     9761       +3     
- Partials     1248     1249       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet marked this pull request as ready for review March 13, 2024 08:30
@qiuming-best qiuming-best merged commit 5d08d62 into vmware-tanzu:main Mar 14, 2024
67 of 69 checks passed
@pavlospt
Copy link

pavlospt commented Jul 5, 2024

@blackpiglet can we please cherry-pick it to release-1.12.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid memory address on Velero restore operation
4 participants