Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not skip unknown gvr at the beginning and get new gr when kind is changed #7523

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

27149chen
Copy link
Contributor

@27149chen 27149chen commented Mar 14, 2024

Please add a summary of your change

In restore, do not skip unknown gvr at the beginning and get new gr when kind is changed

Does your change fix a particular issue?

Fixes #7520

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

…s changed

Signed-off-by: lou <alex1988@outlook.com>
Signed-off-by: lou <alex1988@outlook.com>
Signed-off-by: lou <alex1988@outlook.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 61.72%. Comparing base (5d08d62) to head (19e5f38).
Report is 31 commits behind head on main.

Files Patch % Lines
pkg/restore/restore.go 46.15% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7523      +/-   ##
==========================================
+ Coverage   61.62%   61.72%   +0.09%     
==========================================
  Files         263      263              
  Lines       28688    28872     +184     
==========================================
+ Hits        17678    17820     +142     
- Misses       9761     9794      +33     
- Partials     1249     1258       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/restore/restore.go Show resolved Hide resolved
pkg/restore/restore.go Show resolved Hide resolved
pkg/restore/restore.go Show resolved Hide resolved
pkg/restore/restore.go Show resolved Hide resolved
Signed-off-by: lou <alex1988@outlook.com>
@Lyndon-Li Lyndon-Li merged commit 218aa86 into vmware-tanzu:main Apr 11, 2024
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource auto conversion in restore
3 participants