-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint(ginkgolinter): fix test files #7565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7565 +/- ##
==========================================
- Coverage 61.74% 61.71% -0.03%
==========================================
Files 265 265
Lines 29257 29257
==========================================
- Hits 18064 18056 -8
- Misses 9910 9917 +7
- Partials 1283 1284 +1 ☔ View full report in Codecov by Sentry. |
@mmorel-35 could you explain what was done? you ran something like lint-fix removing this Lines 36 to 37 in 13f4efd
golangci.yaml ?
If the intent is to fix all mentioned error from ginkgolinter, maybe also need to remove this from Lines 21 to 22 in 13f4efd
|
I did a golangci fix after removing _test.go then fix Ginkgolinter errors concerning expect. |
I believe it’s better to keep this pr a draft until #7573 is merged and then turn it into a full fix of ginkgolinter issues |
67ad678
to
13361ca
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please add a summary of your change
Fix Ginkgolinter errors from test files and folders
@blackpiglet ,
This follows #7555 (comment)
Does your change fix a particular issue?
No
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.