Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fix 7648: avoid snapshot leak on expose failure #7662

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

Lyndon-Li
Copy link
Contributor

Fix issue #7648. Adjust the exposing logic to avoid exposing failure and snapshot leak when expose fails

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.76%. Comparing base (f25c154) to head (dcf760d).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/exposer/csi_snapshot.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7662      +/-   ##
==========================================
+ Coverage   61.26%   61.76%   +0.49%     
==========================================
  Files         276      276              
  Lines       31338    24716    -6622     
==========================================
- Hits        19200    15265    -3935     
+ Misses      10784     8098    -2686     
+ Partials     1354     1353       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lyndon-Li Lyndon-Li marked this pull request as ready for review April 12, 2024 03:02
@blackpiglet blackpiglet merged commit c888f51 into vmware-tanzu:main Apr 12, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants