Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code-generator from hack/update-3generated-crd.code.sh #8117

Merged

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Aug 15, 2024

Thank you for contributing to Velero!

Please add a summary of your change

The pkg/generated directory was deleted in PR #8114, but when running make update command, the pkg/generated directory is still created.
The reason is the hack/update-3generated-crd.sh runs the code-generator.
Remove the code-generator.

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.02%. Comparing base (6c3988e) to head (c040207).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8117    +/-   ##
========================================
  Coverage   59.01%   59.02%            
========================================
  Files         358      364     +6     
  Lines       30141    30272   +131     
========================================
+ Hits        17789    17867    +78     
- Misses      10912    10959    +47     
- Partials     1440     1446     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet
Copy link
Contributor Author

There are still some files in the Velero repository that have comments including code-generator, but I think it's OK if we leave it as it is.

@blackpiglet blackpiglet marked this pull request as ready for review August 15, 2024 09:26
Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@shubham-pampattiwar shubham-pampattiwar merged commit a9463ce into vmware-tanzu:main Aug 15, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants