Reduces ~140 indirect imports for plugin/framework importers #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
refactor-pluginframeworkdep
branch
from
93d9257
to
0fe8619
Compare
kaovilai
force-pushed
the
refactor-pluginframeworkdep
branch
from
0fe8619
to
97ec543
Compare
kaovilai
force-pushed
the
refactor-pluginframeworkdep
branch
from
97ec543
to
1457428
Compare
kaovilai
changed the title
kaovilai
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8208 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 30775 30775
=======================================
Hits 18206 18206
Misses 11112 11112
Partials 1457 1457 ☔ View full report in Codecov by Sentry. |
kaovilai
added a commit
to kaovilai/kubevirt-velero-plugin
that referenced
this pull request
Sep 11, 2024
vmware-tanzu/velero#8208 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
to kaovilai/velero-plugin-for-microsoft-azure
that referenced
this pull request
Sep 11, 2024
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
reasonerjt
requested review from
ywk253100
and removed request for
reasonerjt
ywk253100
previously approved these changes
Sep 11, 2024
Lyndon-Li
reviewed
Sep 11, 2024
sseago
previously approved these changes
Sep 11, 2024
3 tasks
kaovilai
force-pushed
the
refactor-pluginframeworkdep
branch
3 times, most recently
from
3b50436
to
cd76cee
Compare
sseago
previously approved these changes
Sep 11, 2024
Lyndon-Li
reviewed
Sep 12, 2024
kaovilai
force-pushed
the
refactor-pluginframeworkdep
branch
2 times, most recently
from
639e69e
to
2d3c8ca
Compare
Lyndon-Li
previously approved these changes
Sep 12, 2024
|
rebasing against #8201 |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
before
```go
❯ find ./pkg/cmd/server/config -maxdepth 1 -type f | grep .go | xargs -I {} sh -c "echo && echo && echo {} && go list -f {{.Deps}} {} | sed 's/ /\n/g' | grep -E 'github.com/vmware-tanzu/velero/pkg/podvolume'"
./pkg/cmd/server/config/config.go
github.com/vmware-tanzu/velero/pkg/podvolume
./pkg/cmd/server/config/config_test.go
```
after
```go
~/git/velero refactor-pluginframeworkdep
❯ find ./pkg/cmd/server/config -maxdepth 1 -type f | grep .go | xargs -I {} sh -c "echo && echo && echo {} && go list -f {{.Deps}} {} | sed 's/ /\n/g' | grep -E 'github.com/vmware-tanzu/velero/pkg/podvolume'"
./pkg/cmd/server/config/config.go
github.com/vmware-tanzu/velero/pkg/podvolume/configs
./pkg/cmd/server/config/config_test.go
```
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
force-pushed
the
refactor-pluginframeworkdep
branch
from
2d3c8ca
to
f232642
Compare
sseago
approved these changes
Sep 12, 2024
ywk253100
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Thank you for contributing to Velero!
Please add a summary of your change
Refactor struct imports to avoid framework importers from needing cloud provider imports.
Moving repository/manager.go to repository/manager/manager.go
This would help a ton with avoiding CVEs false alarms for unrelated plugin.
This change can supplement or replace #8180
Does your change fix a particular issue?
Fixes #8207
Fixes #8157
Problem Demo: vmware-tanzu/velero-plugin-for-microsoft-azure@7e31b61
Fix Demo: vmware-tanzu/velero-plugin-for-microsoft-azure@64ea902
Problem Demo2: kubevirt/kubevirt-velero-plugin@faf9815
Fix Demo2: kubevirt/kubevirt-velero-plugin@2c0e171
Before
After
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.Related: #6484