Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose VSC SourceVolumeMode #8261

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

msfrucht
Copy link
Contributor

@msfrucht msfrucht commented Oct 3, 2024

Thank you for contributing to Velero!

Please add a summary of your change

Copies the VolumeSnapshotContent SourceVolumeMode during DataUpload. Recent versions of the snapshot-controller do not allow the field to be changed from "Filesystem" or "Block" to nil resulting in a failure to move the VolumeSnapshot into the local namespace.

This was found in Kubernetes 1.29/OpenShift 4.16

@shubham-pampattiwar identified the underlying source of the behavior changes to https://kubernetes.io/blog/2024/04/30/prevent-unauthorized-volume-mode-conversion-ga/ and shows up in external-provisioner v4.0.0 and external-snapshotter v7.0.0.

This field is typically nil to begin with in other environments which doesn't trigger this error.

Does your change fix a particular issue?

#8259

Fixes #(issue)

Please indicate you've done the following:

Add changelog and unittest

Signed-off-by: Michael Fruchtman <msfrucht@us.ibm.com>
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.21%. Comparing base (42de654) to head (7580538).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8261   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files         367      367           
  Lines       30841    30842    +1     
=======================================
+ Hits        18262    18263    +1     
  Misses      11119    11119           
  Partials     1460     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfrucht msfrucht marked this pull request as ready for review October 3, 2024 22:14
@Lyndon-Li Lyndon-Li merged commit 14758a3 into vmware-tanzu:main Oct 8, 2024
49 checks passed
@Lyndon-Li
Copy link
Contributor

@msfrucht Please help to cherry-pick this PR to 1.14 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants