-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move storage to libs #2965
Open
yontyon
wants to merge
3
commits into
vmware:master
Choose a base branch
from
yontyon:move-storate-to-libs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move storage to libs #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yontyon
force-pushed
the
move-storate-to-libs
branch
from
March 28, 2023 10:24
b6760c5
to
c411681
Compare
eyalrund
approved these changes
Mar 28, 2023
libs/storage/CMakeLists.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please git mv
this file
@@ -31,7 +31,7 @@ | |||
#include "DbCheckpointMetadata.hpp" | |||
#include "util/Metrics.hpp" | |||
#include "InternalBFTClient.hpp" | |||
#include "storage/db_interface.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and after it should remain #include "storage/db_interface.hpp"
yontyon
force-pushed
the
move-storate-to-libs
branch
3 times, most recently
from
March 30, 2023 08:38
78b079f
to
6dca440
Compare
yontyon
force-pushed
the
move-storate-to-libs
branch
from
April 13, 2023 06:39
6dca440
to
0362640
Compare
yontyon
force-pushed
the
move-storate-to-libs
branch
from
April 16, 2023 04:26
0362640
to
b8247f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move storage library to libs
CI