Implicit copy constructor call removal #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevkovich
suggested changes
Apr 30, 2023
There was a problem hiding this comment.
@titusen , approved, but I suggest to changed according to the comment.
glevkovich
approved these changes
Apr 30, 2023
titusen
force-pushed
the
preprepareMsg_handler_mem_leak_fix
branch
from
a93c854
to
da5ecb1
Compare
eyalrund
approved these changes
May 7, 2023
titusen
force-pushed
the
preprepareMsg_handler_mem_leak_fix
branch
from
da5ecb1
to
7049f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implicit copy constructor call is replaced within direct shred_ptr cstr call in entire file.
Correctness is to be revealed by maestro tests.