Remove duplicated code in ie_value.go #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
===========================================
+ Coverage 60.82% 73.60% +12.77%
===========================================
Files 18 18
Lines 3158 2580 -578
===========================================
- Hits 1921 1899 -22
+ Misses 1037 532 -505
+ Partials 200 149 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
previously approved these changes
Sep 10, 2021
zyiou
reviewed
Sep 10, 2021
Comment on lines
+179
to
+183
| infoElem := &Unsigned8InfoElement{ | ||
| value: val, | ||
| } | ||
| infoElem.element = element | ||
| return infoElem |
There was a problem hiding this comment.
How about writing it in this way:
return &Unsigned8InfoElement{
value: val,
element: element,
}
There was a problem hiding this comment.
Embedded element cannot be accessed like that.
pkg/entities/ie_value.go
Outdated
Comment on lines
216
to
217
| func (u16 *Unsigned16InfoElement) GetUnsigned16Value() (uint16, error) { | ||
| return u16.value, nil |
There was a problem hiding this comment.
Do we still need to return error here?
There was a problem hiding this comment.
Good catch. Not needed. The rest of the code that uses these get and set functions becomes simpler.
pkg/entities/ie_value.go
Outdated
| return false, fmt.Errorf("accessing value of wrong data type") | ||
| func (u16 *Unsigned16InfoElement) SetUnsigned16Value(val uint16) error { | ||
| u16.value = val | ||
| return nil |
srikartati
force-pushed
the
remove_code_duplication
branch
from
bfe71ec
to
ec6b8b9
Compare
zyiou
previously approved these changes
Sep 13, 2021
pkg/entities/ie_value.go
Outdated
| IsValueEmpty() bool | ||
| GetLength() int | ||
| ResetValue() | ||
| } | ||
|
|
||
| type Unsigned8InfoElement struct { | ||
| value uint8 | ||
| type BaseInfoElement struct { |
There was a problem hiding this comment.
Is it necessary to make this type public? I didn't see it is used outside this package.
There was a problem hiding this comment.
Not needed. Modified.
There is lot of repeated code. Base structure can help in removing that.
srikartati
force-pushed
the
remove_code_duplication
branch
from
ec6b8b9
to
514b71f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is lot of repeated code. Base structure
can help in removing that.