Use correct default value for templateRefreshTimeout #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct recommended default is 600s, not 1800s. 1800s is the recommended default for templateLifeTime (3 times templateRefreshTimeout). We also update the UDP collector process to timeout the client after templateLifeTime instead of templateRefreshTimeout. This makes more sense as templateLifeTime is a collector process configuration parameter, while templateRefreshTimeout is for the exporter process. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added a commit
to antoninbas/vmware-go-ipfix
that referenced
this pull request
Sep 10, 2024
The default for the template refresh timeout is 600s, not 1800s. This should have been modified as part of vmware#353. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
added a commit
that referenced
this pull request
Sep 12, 2024
The default for the template refresh timeout is 600s, not 1800s. This should have been modified as part of #353. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct recommended default is 600s, not 1800s. 1800s is the recommended default for templateLifeTime (3 times
templateRefreshTimeout).
We also update the UDP collector process to timeout the client after templateLifeTime instead of templateRefreshTimeout. This makes more sense as templateLifeTime is a collector process configuration parameter, while templateRefreshTimeout is for the exporter process.