-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to create, get, publish and delete UI plugins #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambarreiro
changed the title
Add methods to create, get and delete UI plugins
Add methods to create, get, publish and delete UI plugins
May 22, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
requested review from
lvirbalas,
Didainius,
dataclouder and
adezxc
as code owners
June 1, 2023 10:17
adezxc
approved these changes
Jun 5, 2023
lvirbalas
reviewed
Jun 7, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
approved these changes
Jun 8, 2023
Didainius
reviewed
Jun 14, 2023
Didainius
approved these changes
Jun 14, 2023
Didainius
reviewed
Jun 14, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
dataclouder
approved these changes
Jun 21, 2023
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
added a commit
that referenced
this pull request
Jun 29, 2023
* Fix UI Plugin unit tests that fail due to change #575 Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds several new methods to be able to programatically manipulate UI plugins:
In
VCDClient
:In new type
UIPlugin
:Tests
Tested on 10.4.2, 10,3.3, 10.3.0