Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods to create, get, publish and delete UI plugins #575

Merged
merged 30 commits into from
Jun 23, 2023
Merged

Add methods to create, get, publish and delete UI plugins #575

merged 30 commits into from
Jun 23, 2023

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented May 22, 2023 •
edited
Loading

Overview

This PR adds several new methods to be able to programatically manipulate UI plugins:

  • In VCDClient:

    • New method to add a new UI plugin, which picks the required metadata from a given ZIP file and performs the upload to VCD.
    • New methods to retrieve all UI plugins, a specific UI plugin by its URN, or a specific plugin defined by its unique combination of vendor, plugin name and version.

  • In new type UIPlugin:

    • New methods to update the given UI plugin. Only can update the Enabled, ProviderScoped and TenantScoped flags. The other properties are read-only and specified on plugin upload.
    • New methods to publish and unpublish the given UI plugin to specific or all tenants.
    • New method to delete the given UI plugin.

Tests

Tested on 10.4.2, 10,3.3, 10.3.0

@adambarreiro
Init
54ea7c8 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
72f91f5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add and Delete. Tests pass
0ac7298 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Changelog
22001ec 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro changed the title Add methods to create, get and delete UI plugins Add methods to create, get, publish and delete UI plugins May 22, 2023
@adambarreiro
Move to dummy plugin
ba1eef4 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Move to dummy plugin
70ba7ef 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add methods. Tests passing
10d8b27 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Finished. Tests passing
7deade0 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add enabled disabled methods. Tests passing
243de5f 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add update method. Tests passing
e3952d9 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
81e6847 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
2060cd1 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
c1d690a 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
f13d9e8 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
13a39df 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
3ae07bf 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add test
82c3fe6 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix
c08a6f5 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
#
0c2043c 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Add status
e6e6ef3 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro mentioned this pull request May 26, 2023
Merged
@adambarreiro adambarreiro marked this pull request as ready for review June 1, 2023 10:17
adezxc
adezxc approved these changes Jun 5, 2023
View reviewed changes
.changes/v2.21.0/575-features.md Outdated Show resolved Hide resolved
@adambarreiro
Typo
6252ffa 
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
lvirbalas reviewed Jun 7, 2023
View reviewed changes
govcd/api_vcd_test.go Outdated Show resolved Hide resolved
@adambarreiro
Changed test tags
46f3125 
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
Didainius reviewed Jun 14, 2023
View reviewed changes
govcd/ui_plugin_test.go Outdated Show resolved Hide resolved
@adambarreiro
Improve tests
64b625e 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Split unit and functional tests
9361995 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix logging
f2cea6d 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix
0d1f15e 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix
1e341d1 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix logging
0a44642 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Fix logging
d8024db 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro
Improve error msg
1c5d2da 
Signed-off-by: abarreiro <abarreiro@vmware.com>
@adambarreiro adambarreiro merged commit d2c75b7 into vmware:main Jun 23, 2023
2 checks passed
@adambarreiro adambarreiro deleted the add-ui-plugin-mgmt branch June 23, 2023 07:36
@adambarreiro adambarreiro mentioned this pull request Jun 26, 2023
Merged
adambarreiro added a commit that referenced this pull request Jun 29, 2023
@adambarreiro
Fix UI Plugin unit tests that fail (#583)
be0efa9 
* Fix UI Plugin unit tests that fail due to change #575
Signed-off-by: abarreiro <abarreiro@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@dataclouder dataclouder dataclouder approved these changes

@adezxc adezxc adezxc approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adambarreiro @lvirbalas @dataclouder @Didainius @adezxc @vmwclabot