Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP Spaces CRUD #578

Merged
merged 10 commits into from
Jun 20, 2023
Merged

IP Spaces CRUD #578

merged 10 commits into from
Jun 20, 2023

Conversation

Didainius
Copy link
Collaborator

This PR adds support for IP Spaces. It is the first PR which exposes CRUD API for IP Spaces. Next PRs will contain the integration part with the rest of components.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review May 31, 2023 06:34
@Didainius Didainius mentioned this pull request Jun 1, 2023
types/v56/ip_space.go Outdated Show resolved Hide resolved
types/v56/ip_space.go Outdated Show resolved Hide resolved
govcd/ip_space.go Show resolved Hide resolved
govcd/ip_space.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
govcd/ip_space.go Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass in all versions
LGTM

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit b08ab12 into vmware:main Jun 20, 2023
@Didainius Didainius deleted the ipspaces1 branch June 20, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants