Create Vapp from template or from other vApp #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 11, 2023 18:31
* Wrong implementation (PUT instead of POST) * Wrong result (returns a task instead of a vApp) Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
added 4 commits
July 12, 2023 08:42
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
dataclouder
requested review from
lvirbalas,
Didainius,
adambarreiro and
adezxc
as code owners
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
lvirbalas
approved these changes
Jul 13, 2023
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
adezxc
approved these changes
Jul 13, 2023
adambarreiro
approved these changes
Jul 13, 2023
added 3 commits
July 13, 2023 12:36
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Didainius
approved these changes
Jul 13, 2023
Signed-off-by: Giuseppe Maxia <gmaxia@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #741
Adds methods:
vdc.CreateVappFromTemplatevdc.CloneVappvapp.DiscardSuspendedStateTesting
Using
test_resources/vapp_with_3_vms.ova, make a vApp template namedthree-vmsin the main NSX-T catalog (cat-{ORG_NAME}-nsxt-backed).Run
go test -v -tags vapp -check.f TestVappfromTemplateAndClone