-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for topology intentions to provider gateways (VCD 10.5.1+) (NAT, FW, Route Advertisement) #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
changed the title
Add support for IP Space NAT and Firewall Rule intention configuration (VCD 10.5.1+)
Add support for NAT and Firewall Rule intention configuration in IP Space based provider gateways (VCD 10.5.1+)
Mar 26, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
changed the title
Add support for NAT and Firewall Rule intention configuration in IP Space based provider gateways (VCD 10.5.1+)
Add support for NAT, Firewall and Route Advertisement intentions to provider gateways (VCD 10.5.1+)
Mar 27, 2024
Didainius
changed the title
Add support for NAT, Firewall and Route Advertisement intentions to provider gateways (VCD 10.5.1+)
Add support topology intentions to provider gateways (VCD 10.5.1+) (nat,fw,route advertisement)
Mar 27, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
April 10, 2024 10:16
adambarreiro
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
dataclouder
approved these changes
Jun 7, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
lvirbalas
changed the title
Add support topology intentions to provider gateways (VCD 10.5.1+) (nat,fw,route advertisement)
Add support for topology intentions to provider gateways (VCD 10.5.1+) (NAT, FW, Route Advertisement)
Jun 19, 2024
lvirbalas
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new fields for provider gateway (external network) topology intentions that are available on VCD 10.5.1+ and require API v38.1