Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for topology intentions to provider gateways (VCD 10.5.1+) (NAT, FW, Route Advertisement) #660

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Mar 26, 2024

This PR adds 2 new fields for provider gateway (external network) topology intentions that are available on VCD 10.5.1+ and require API v38.1

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Add support for IP Space NAT and Firewall Rule intention configuration (VCD 10.5.1+) Add support for NAT and Firewall Rule intention configuration in IP Space based provider gateways (VCD 10.5.1+) Mar 26, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title Add support for NAT and Firewall Rule intention configuration in IP Space based provider gateways (VCD 10.5.1+) Add support for NAT, Firewall and Route Advertisement intentions to provider gateways (VCD 10.5.1+) Mar 27, 2024
@Didainius Didainius changed the title Add support for NAT, Firewall and Route Advertisement intentions to provider gateways (VCD 10.5.1+) Add support topology intentions to provider gateways (VCD 10.5.1+) (nat,fw,route advertisement) Mar 27, 2024
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review April 10, 2024 10:16
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.changes/v2.24.0/660-improvements.md Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
.changes/v2.25.0/660-improvements.md Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@lvirbalas lvirbalas changed the title Add support topology intentions to provider gateways (VCD 10.5.1+) (nat,fw,route advertisement) Add support for topology intentions to provider gateways (VCD 10.5.1+) (NAT, FW, Route Advertisement) Jun 19, 2024
@Didainius Didainius merged commit c6d395d into vmware:main Jun 19, 2024
2 checks passed
@Didainius Didainius deleted the natfwintention branch June 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants