Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSE cluster creation when using VDC Groups #674

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix CSE cluster creation when using VDC Groups #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e19af
Fix CSE cluster creation in VDC Groups
May 10, 2024
ead2f0f
#
May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changes/v2.25.0/674-bug-fixes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
* Fixed a bug that caused CSE Kubernetes cluster creation to fail when the configured Organization VDC Network belongs to
a VDC Group [GH-674]
3 changes: 2 additions & 1 deletion govcd/cse_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ func cseConvertToCseKubernetesClusterType(rde *DefinedEntity) (*CseKubernetesClu
// Retrieve the Network ID
params := url.Values{}
params.Add("filter", fmt.Sprintf("name==%s", result.capvcdType.Status.Capvcd.VcdProperties.OrgVdcs[0].OvdcNetworkName))
params = queryParameterFilterAnd("ownerRef.id=="+result.VdcId, params)
params = queryParameterFilterAnd("orgVdc.id=="+result.VdcId, params)
params = queryParameterFilterAnd("_context==includeAccessible", params)
networks, err := getAllOpenApiOrgVdcNetworks(rde.client, params)
if err != nil {
return nil, fmt.Errorf("could not read Org VDC Network from Capvcd type: %s", err)
Expand Down
Loading