Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NSX-T Edge Gatway IP count limits #682

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jun 3, 2024

This PR modifies internal function flattenEdgeGatewayUplinkToIpSlice to support limits of counting IPs as in the cases of large IPv6 subnets counting all IPs can exhaust compute resource and crash the process.

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius changed the title WIP: Support NSX-T Edge Gatway IP count limits Support NSX-T Edge Gatway IP count limits Jun 4, 2024
@Didainius Didainius marked this pull request as ready for review June 4, 2024 11:56
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

.changes/v2.25.0/682-improvements.md Outdated Show resolved Hide resolved
@Didainius Didainius merged commit 3167110 into vmware:main Jun 19, 2024
2 checks passed
@Didainius Didainius deleted the ipv6-large-subnets branch June 19, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants