Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CSV format response in QueryPerf API #3103

Closed
jsleblanc opened this issue Apr 17, 2023 · 0 comments · Fixed by #3104
Closed

Support CSV format response in QueryPerf API #3103

jsleblanc opened this issue Apr 17, 2023 · 0 comments · Fixed by #3104

Comments

@jsleblanc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
QueryPerf API PerfQuerySpec argument allows clients to specify the return format for performance counter data ("normal", "csv"); using CSV format is recommended by vmware for performance reasons, but govcsim does not support the format property at this time. Clients that request performance counter data in CSV format will not receive data in the format they expect.

https://vdc-repo.vmware.com/vmwb-repository/dcr-public/c476b64b-c93c-4b21-9d76-be14da0148f9/04ca12ad-59b9-4e1c-8232-fd3d4276e52c/SDK/vsphere-ws/docs/ReferenceGuide/vim.PerformanceManager.QuerySpec.html

https://vdc-repo.vmware.com/vmwb-repository/dcr-public/c476b64b-c93c-4b21-9d76-be14da0148f9/04ca12ad-59b9-4e1c-8232-fd3d4276e52c/SDK/vsphere-ws/docs/ReferenceGuide/vim.PerformanceManager.Format.html

https://vdc-repo.vmware.com/vmwb-repository/dcr-public/c476b64b-c93c-4b21-9d76-be14da0148f9/04ca12ad-59b9-4e1c-8232-fd3d4276e52c/SDK/vsphere-ws/docs/ReferenceGuide/vim.PerformanceManager.EntityMetricCSV.html

Describe the solution you'd like
When format is specified as "csv" on the PerfQuerySpec argument to QueryPerf, return performance counter data in CSV format, otherwise return data in the "normal" format - the behaviour of govcsim today.

Describe alternatives you've considered
Behaviour is defined by the vmware API; this is just a small gap in govcsim implementation at this time.

jsleblanc added a commit to jsleblanc/govmomi that referenced this issue Apr 17, 2023
jsleblanc added a commit to jsleblanc/govmomi that referenced this issue Apr 17, 2023
dougm added a commit that referenced this issue Apr 17, 2023
govcsim: Add CSV format support to QueryPerf API; Closes #3103
dougm pushed a commit that referenced this issue Jun 27, 2023
priyanka19-98 pushed a commit to priyanka19-98/govmomi that referenced this issue Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant