Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated types to vCenter 7.0U3 (build 18700403) #2618

Merged
merged 5 commits into from
Oct 13, 2021

Conversation

zach96guan
Copy link
Member

@zach96guan zach96guan commented Oct 11, 2021

Description

This patch updates the file gen/gen.sh to use vCenter 7.0U3 (build 18700403) as the source for generating types and client bindings for the following packages:

  • vim25
  • eam
  • pbm
  • sms (no update)
  • vlsm

Closes: #2612

Type of change

Please mark options that are relevant:

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

The following commands were executed locally:

make lint
make install
make test

None of the above checks produced any errors.

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@yuyin002
Copy link

Thanks for the change! Would you mind documenting the VC build you used to generate the types?

@zach96guan
Copy link
Member Author

zach96guan commented Oct 11, 2021

Thanks for the change! Would you mind documenting the VC build you used to generate the types?

TFTR! Add the build number for reference

@zach96guan zach96guan changed the title fix: Regenerate upstream EAM bindings to include UseUuidVmName Update generated types to vCenter 7.0U3 (build 18700403) Oct 12, 2021
eam/simulator/agency.go Outdated Show resolved Hide resolved
dougm
dougm previously approved these changes Oct 13, 2021
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , thanks @zach96guan

Copy link
Member

@HakanSunay HakanSunay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat, thanks Zach :)

@zach96guan zach96guan merged commit ffd45c8 into vmware:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] useUuidVmName is missing in upstream EAM bindings
6 participants