-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support finding Portgroups by ID in Finder.Network #2626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With standard vSphere networking, Portgroups cannot have the same name within the same network folder. With NSX, Portgroups can have the same name, even within the same Switch. In this case, using an inventory path results in a MultipleFoundError. A MOID, switch UUID or segment ID can be used instead, as both are unique. - Add ContainerView.FindAny method - Add nsx backing and SegmentId defaults to the simulator for testing - Add simulator support for renaming a Portgroup, only allowing nsx to have duplicate names
saimanoj01
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks a lot for the quick fix.
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Feb 8, 2023
Rather than limit by ID search to find.Network, move the logic to NetworkList to support both methods. Add finder_test (meant to include with PR vmware#2626)
5 tasks
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Feb 8, 2023
Rather than limit by ID search to find.Network, move the logic to NetworkList to support both methods. Add finder_test (meant to include with PR vmware#2626)
dougm
added a commit
to dougm/govmomi
that referenced
this pull request
Feb 8, 2023
Rather than limit by ID search to find.Network, move the logic to NetworkList to support both methods. Add finder_test (meant to include with PR vmware#2626)
dougm
added a commit
that referenced
this pull request
Mar 16, 2023
Rather than limit by ID search to find.Network, move the logic to NetworkList to support both methods. Add finder_test (meant to include with PR #2626)
priyanka19-98
pushed a commit
to priyanka19-98/govmomi
that referenced
this pull request
Jan 17, 2024
Rather than limit by ID search to find.Network, move the logic to NetworkList to support both methods. Add finder_test (meant to include with PR vmware#2626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With standard vSphere networking, Portgroups cannot have the same name within the same network folder.
With NSX, Portgroups can have the same name, even within the same Switch. In this case, using an inventory path
results in a MultipleFoundError. A MOID, switch UUID or segment ID can be used instead, as both are unique.
Note that applications using
Finder.Network
do not require any code changes to use this functionality. Only the go module dependency needs to be bumped to include this change.Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
-net
flags with MOID, Switch UUID and Segment IDChecklist:
this project