Move to graceful reload endpoint and error #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimm609
force-pushed
the
reloader_endpoint
branch
from
39c8620
to
53dc9fb
Compare
|
should we also add documentation link with the MR or commit ? |
Move to gracefulReload endpoint to align with upstream docs after 1.9 Change failure to an error instead of info "If you use fluentd v1.9.0 or later, use SIGUSR2 instead of SIGHUP" "/api/config.gracefulReload SIGUSR2 Reloads configuration." ref: https://docs.fluentd.org/deployment/signals#sigusr2 Signed-off-by: Brian Davis <slimm609@gmail.com>
slimm609
force-pushed
the
reloader_endpoint
branch
from
53dc9fb
to
17099e0
Compare
Cryptophobia
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
lgtm! very nice find @slimm609 ! "graceful" is always better
Cryptophobia
pushed a commit
to Cryptophobia/kube-fluentd-operator
that referenced
this pull request
Oct 19, 2021
- reverting vmware#189 - there are too many old plugins which do not support gracefulReload yet Signed-off-by: Anton Ouzounov <aouzounov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to gracefulReload endpoint to align with upstream docs after 1.9
Change failure to an error instead of info
Signed-off-by: Brian Davis slimm609@gmail.com