Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#289 Mounted file issue fix part-2 #306

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Issue#289 Mounted file issue fix part-2 #306

merged 3 commits into from
Feb 11, 2022

Conversation

vkadi
Copy link
Contributor

@vkadi vkadi commented Feb 2, 2022

Signed-off-by: vkadi kadiyan.vandana@gmail.com

@vkadi
Issue#289 Mounted file issue fix part-2
58dc72d 
Signed-off-by: vkadi <kadiyan.vandana@gmail.com>
@vkadi vkadi mentioned this pull request Feb 2, 2022
Closed
@sabdalla80 sabdalla80 mentioned this pull request Feb 2, 2022
Open
Cryptophobia
Cryptophobia approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Cryptophobia
Copy link
Contributor

Cryptophobia commented Feb 3, 2022 •
edited
Loading

@desponda @slimm609 @javiercri ,

This is good simple fix and will fix problems with v1.16.1 and reverts the code that has to be reverted here in this PR: #293 . Please merge when you can and close #289 .

Fixes and closes: #289
Reverts non-scalable code in big clusters: https://github.com/vmware/kube-fluentd-operator/pull/293/files#diff-02dff57051ef7647011ad2da41c65fc9600bed4d6e4178bb85fd47d0c0c98509R263-R279

@javiercri
Copy link
Contributor

@vkadi lint is failing. Could you fix this one?

@vkadi
Fixing lint issues
058ebf3 
Signed-off-by: Vandana Kadiyan <kadiyan.vandana@gmail.com>
@vkadi
Other liniting issues ..
c8d7210 
Signed-off-by: Vandana kadiyan <kadiyan.vandana@gmail.com>
@javiercri
Copy link
Contributor

LGTM!
Thanks for the PR!

@javiercri javiercri merged commit bef7a7e into vmware:master Feb 11, 2022
@vkadi vkadi deleted the mounted-file-issue branch February 11, 2022 16:34
@vkadi
Copy link
Contributor Author

vkadi commented Mar 23, 2022

@javiercri Wondering, if we need to create a new tag to have these changes in v1.16.3 ? Or if I pull latest v1.16.2 I will have this fix in that, since its merged in master? Can you please share how are release planned for this project...

@javiercri
Copy link
Contributor

@vkadi Ey, yeah we need to create a new tag. Let me finish some issues, i think i will generate a new release next week. Sorry for the delay

@vkadi
Copy link
Contributor Author

vkadi commented Apr 15, 2022

@Cryptophobia @javiercri I am observing the boot time for fluentd container has increased(double the time) in v1.16.3, Is this expected?
Also, is there any slack/telegram channel where we can reach out with these generic question or support?

This was referenced May 26, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercri javiercri javiercri approved these changes

@Cryptophobia Cryptophobia Cryptophobia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkadi @Cryptophobia @javiercri