Vmomi support pep8 #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 31, 2014 01:26
This big change is mostly fixing indents and renaming a few local variables, and a few method names to make them pep 8 style. This change took the pylint global score from almost -6 to 3.79/10 There is a lot left to do in this file to make pylint happy.
|
The truth is, I'm being very cautious with the library right now. Edit: BTW: yeah, this is about the right way to do this. We want the change sets to be very easily isolate-able (because we don't want things breaking and if they do we want to be able to back out easily). I've not decided if this should be one pull request per change set or not but making these easy to review is the right direction. |
| @@ -1,3 +1,4 @@ | |||
| *.pyc | |||
| build | |||
| dist | |||
| *.idea | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasnt sure how yall want things like this so I did a commit for each isolated change. Let me know if you would rather have a pull request for each thing instead, or if you want me to rebase all this into 1.
I have tested this with the samples and it is working fine. Its mostly just indent fixes, and some variable name changes to make pylint a little more happy.