vdk-notebook: handle job with mixed .ipynb, .py, .sql files use-case #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivakoleva
approved these changes
Jun 20, 2023
projects/vdk-plugins/vdk-notebook/src/vdk/plugin/notebook/notebook.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
force-pushed
the
person/hduygu/vdk-notebook-sort-mixed-run
branch
from
72dee34
to
2a60253
Compare
gageorgiev
approved these changes
Jun 21, 2023
mivanov1988
pushed a commit
that referenced
this pull request
Jun 21, 2023
…2279) What: Added string function to the stepBuilder, which is being called when a new notebook step is added to the job. This ensures that the steps are executed alphanumerically. Why: currently, when we execute "vdk run" firstly all the python and sql files are executed and then the notebook files (which is not expected since we expect vdk run to run files alphanumerically) Signed-off-by: Duygu Hasan [hduygu@vmware.com](mailto:hduygu@vmware.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added string function to the stepBuilder, which is being called when a new notebook step is added to the job.
This ensures that the steps are executed alphanumerically.
Why:
currently, when we execute "vdk run" firstly all the python and sql files are executed and then the notebook files (which is not expected since we expect vdk run to run files alphanumerically)
Signed-off-by: Duygu Hasan hduygu@vmware.com