control-service: switch to Approle Vault authentication #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using Approle for Vault Authentication rather than Tokens. https://developer.hashicorp.com/vault/docs/auth/approle https://developer.hashicorp.com/vault/tutorials/auth-methods/approle Update service code, VEP, Tests and helm charts. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Codacy checks. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Add support for token authentication for dev purposes. Signed-off-by: Dako Dakov <ddakov@vmware.com>
mivanov1988
approved these changes
Jul 21, 2023
antoniivanov
approved these changes
Jul 21, 2023
...control-service/projects/pipelines_control_service/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
...ontrol_service/src/main/java/com/vmware/taurus/secrets/service/vault/VaultConfiguration.java
Show resolved
Hide resolved
...egration-test/java/com/vmware/taurus/secrets/service/vault/TestVaultJobSecretsServiceIT.java
Outdated
Show resolved
Hide resolved
Address review feedback. Signed-off-by: Dako Dakov <ddakov@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using Approle for Vault Authentication rather than Tokens.
Approle authentication is more suitable for long running applications,
like the Control Service.
https://developer.hashicorp.com/vault/docs/auth/approle
https://developer.hashicorp.com/vault/tutorials/auth-methods/approle
Update service code, VEP, Tests and helm charts.