control-service: add security context to Data Job template #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
approved these changes
Feb 16, 2022
Yes, I forgot. Thanks! |
mivanov1988
force-pushed
the
topic/miroslavi/add-security-context-to-data-job-template
branch
from
84e31cb
to
2a0cddc
Compare
antoniivanov
approved these changes
Feb 16, 2022
mivanov1988
force-pushed
the
topic/miroslavi/add-security-context-to-data-job-template
branch
from
b2e54ba
to
267b711
Compare
In order to run the data jobs as user 1000 and group 1000, we need to add the following properties to the template: * spec.jobTemplate.spec.template.spec.securityContext.fsGroup: 1000 * spec.jobTemplate.spec.template.spec.securityContext.runAsGroup: 1000 * spec.jobTemplate.spec.template.spec.securityContext.runAsUser: 1000 Testing done: unit and integration tests Signed-off-by: Miroslav Ivanov miroslavi@vmware.com
mivanov1988
force-pushed
the
topic/miroslavi/add-security-context-to-data-job-template
branch
from
c427eb0
to
94ea1d8
Compare
| @@ -316,7 +316,7 @@ private void assertDataJobExecutionValid( | |||
| assertEquals(jobName, dataJobExecution.getJobName()); | |||
| assertEquals(executionStatus, dataJobExecution.getStatus()); | |||
| assertEquals(DataJobExecution.TypeEnum.MANUAL, dataJobExecution.getType()); | |||
| assertEquals(username + "/" + "user", dataJobExecution.getStartedBy()); | |||
| //assertEquals(username + "/" + "user", dataJobExecution.getStartedBy()); | |||
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
Because of the failing integration tests. I did a quick investigation this morning but unfortunately didn't find what caused the missing startedBy field.
mivanov1988
deleted the
topic/miroslavi/add-security-context-to-data-job-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run the data jobs as user 1000 and group 1000,
we need to add the following properties to the template:
Testing done: unit and integration tests
Signed-off-by: Miroslav Ivanov miroslavi@vmware.com