Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker stats --no-stream might hang indefinitely #4585

Closed
cgtexmex opened this issue Apr 5, 2017 · 0 comments
Closed

docker stats --no-stream might hang indefinitely #4585

cgtexmex opened this issue Apr 5, 2017 · 0 comments
Assignees
Labels
area/docker Support for the Docker operations priority/p0
Milestone

Comments

@cgtexmex
Copy link
Contributor

cgtexmex commented Apr 5, 2017

if a user calls docker stats --no-stream before any stats are available for a given VM (i.e. it just started and no stats have been generated) then the call will not return.

The only remedy is for a user to cancel the request.

@cgtexmex cgtexmex added area/docker Support for the Docker operations priority/p0 labels Apr 5, 2017
@cgtexmex cgtexmex added this to the Sprint 6 milestone Apr 5, 2017
@cgtexmex cgtexmex self-assigned this Apr 5, 2017
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 5, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%.

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%.

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%.

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90%

Fixes vmware#4549, vmware#4585
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 6, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 8, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 8, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 10, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 10, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
@mhagen-vmware mhagen-vmware modified the milestones: Sprint 6, Sprint 7 Apr 12, 2017
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 13, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 13, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 13, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
cgtexmex pushed a commit to cgtexmex/vic that referenced this issue Apr 14, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
matthewavery pushed a commit to matthewavery/vic that referenced this issue May 3, 2017
In some cases a race could be encountered when executing docker
stats.  The race would result in an orphaned go routine that
would be a memory leak.

In addition if stats --no-stream -all was requested the persona
would hang on any stopped containers.  Stats now will consider
the container state when processing these requests.

Finally, the unit testing coverage was increased to just over
90% and integration tests were created.

Fixes vmware#4549, vmware#4585, vmware#4421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker Support for the Docker operations priority/p0
Projects
None yet
Development

No branches or pull requests

2 participants