Add bonneville-container #4
Conversation
|
We should avoid adding binary files to this clean repository. Thoughts? |
|
Good catch, @dougm! Most of the bin files are for dos and I'm sure we don't need them in VIC. The isolinux file and the empty image file I'm sure we don't need or can pull from somewhere of we do. I didn't notice these and will take care of this. |
|
Ivan uses https://raw.githubusercontent.com/go-swagger/go-swagger/master/hack/add-license.sh to add license header to the files |
| @@ -0,0 +1,61 @@ | |||
| FROM golang:1.5.3 | |||
|
|
|||
| RUN apt-get update && apt-get -y install curl cpio ssh-client squashfs-tools xorriso git gcc make vim patch rpm busybox-static | |||
There was a problem hiding this comment.
Do we really need gcc/make/vim and patch here?
There was a problem hiding this comment.
Nope. This is from "upstream". Will nuke this in another PR.
|
@caglar10ur nice! I had a bash 4-liner, but this works too. |
From 0f873f91f5936ae50d1d470ce603c54af0faa148. The targets/linux/Dockerfile needs some updating since it refers to isolinux.bin and boot.cat which were originally in the repo. We can pull these from external hosts or the build container directly. Will fix this in the near future.
This change removes the copying of targets/*/*.go into the build container to build specific targets. Instead all OS specific files are in the same package and the go compiler can figure out what OS it's building for to include the appropriate file. Proxy was moved to tether/cmd/proxy/. Since it implements a completely independent binary, this made the most sense. The result of all of this is (after running gpm get) you can now build locally by using go build directly.
We were embedding the binaries in the repo and including them in xorriso. Instead, use syslinux and isolinux from the build container.
Removed the enatai-gerrit paths in the package namespaces and updated the Dockerfiles.
|
We still have to figure out what to do about the photon kernel. It's currently being pulled from a jenkins build. |
|
I suggest moving bonneville-kernel into the vic repo and then building it via drone and consume that artifact - until photon provides a kernel RPM that we can consume directly from their binary repo. |
|
This is an option. I'd like to leave the kernel as an open issue and leave it out of this PR. Other than the kernel, this PR is ready to go from my perspective. |
|
|
👍 💯
From commit 0f873f91f5936ae50d1d470ce603c54af0faa148 of bonneville-container.
Still need to add the license header to all files. Will do that in a future change.
Also includes refactor so we can build things locally.