This repository has been archived by the owner on Apr 25, 2022. It is now read-only.
dec: Add support for XOR-cipher Valkyria ODN archives #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variant is used for all script archives
ghost
commented
Sep 26, 2021
| while (true) | ||
| { | ||
| auto entry = std::make_unique<dec::PlainArchiveEntry>(); | ||
| entry->path = input_stream.read(8).str(); | ||
| entry->offset = hex_to_int(input_stream.read(8)); | ||
| if (entry->path.str().substr(0, 4) == "END_") | ||
| if (entry->path == "END_ffff" || entry->path == "ffffffff") |
There was a problem hiding this comment.
There are apparently several variants for the terminator. I added the variation I saw after decryption of the archive.
ghost
commented
Sep 27, 2021
| @@ -113,6 +113,7 @@ static void read_meta_v1( | |||
| dec::ArchiveMeta *meta, | |||
| io::BaseByteStream &input_stream) | |||
| { | |||
| input_stream.seek(0); | |||
There was a problem hiding this comment.
Addressed a small issue where the decoder was skipping over the first file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant is used for all script archives
Having access to the plain-text scripts could allow for fan translations