Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: rename parameter csv_path -> dataset_path #549

Closed
Tracked by #614
NickleDave opened this issue Jul 23, 2022 · 0 comments · Fixed by #632
Closed
Tracked by #614

ENH: rename parameter csv_path -> dataset_path #549

NickleDave opened this issue Jul 23, 2022 · 0 comments · Fixed by #632
Assignees
@NickleDave

Comments

@NickleDave
Copy link
Collaborator

To simultaneously be more specific (because there are other .csv paths) and be more general (because a dataset may not always be a .csv)

Probably not a good idea to heavily overload the semantics of this argument--e.g. by allowing dataset_path to be any of 12 different things--but it repeatedly annoys me that the name csv_path is not very clear from context.
Maybe dataset_csv_path? But that's starting to get pretty verbose
@NickleDave NickleDave self-assigned this Jul 23, 2022
@NickleDave NickleDave mentioned this issue Jan 17, 2023
Open
44 tasks
NickleDave added a commit that referenced this issue Feb 24, 2023
@NickleDave
ENH: Rename config option csv_path -> dataset_path, fix #549
08f70b8 
because `csv_path` is not very specific, and because
the path to a dataset may not always be
the path to a csv (although it is for now)

- Rename `csv_path` -> `dataset_path` in vak/config
- Rename `csv_path` -> `dataset_path` in vak/core
- Rename `csv_path` -> `dataset_path` in vak/cli
- Rename `csv_path` -> `dataset_path` in tests
@NickleDave NickleDave mentioned this issue Feb 24, 2023
Merged
NickleDave added a commit that referenced this issue Feb 24, 2023
@NickleDave
MRG: #633 from vocalpy/rename-csv-path-dataset-path
01f8ea0 
ENH: Rename config option `csv_path` -> `dataset_path`, fix #549
NickleDave added a commit that referenced this issue Feb 24, 2023
@NickleDave
ENH: Rename config option csv_path -> dataset_path, fix #549
056372e 
because `csv_path` is not very specific, and because
the path to a dataset may not always be
the path to a csv (although it is for now)

- Rename `csv_path` -> `dataset_path` in vak/config
- Rename `csv_path` -> `dataset_path` in vak/core
- Rename `csv_path` -> `dataset_path` in vak/cli
- Rename `csv_path` -> `dataset_path` in tests
NickleDave added a commit that referenced this issue Feb 24, 2023
@NickleDave
MRG: #632 from vocalpy/rename-csv-path-dataset-path
6124d5a 
Rename csv path dataset path, fix #549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickleDave NickleDave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename csv path dataset path, fix #549 vocalpy/vak
1 participant
@NickleDave