TST/CI: refactor test suite to use TeenyTweetyNet, fix #330 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickleDave
force-pushed
the
use-teenytweetynet-in-tests
branch
2 times, most recently
from
2c29b8a
to
54e0165
Compare
generating test data:
- rename tweetynet configs
- add teenytweetynet configs
- modify test_data_generate.py script
- so it finds all configs
- have it make model subdirectories in results/
- rewrite Makefile
- differentiate 'all' and 'ci' generated test data
- change commands, variables, urls to data
refactoring tests:
- add `model` parameters to fixtures:
- to `specific_config` fixture
- to `specific_config_toml` fixture
- to `dataframe` fixtures
- change `previous_run_path` fixture to `previous_run_path_factory`
- use `model` as argument to `_previous_run_path` function
returned by factory
- add `models` command-line option for pytest
+ that will parametrize any test that specifies `models` fixture
with whatever arguments are passed in at command line
- use `model` fixture in tests
- add model fixture to unit tests in test_core/ and test_cli/
- use `model` fixture in a test in test_labeled_timebins
- use `previous_run_path_factory` with `model` in
test_cli/test_learncurve.py
- also add `default_model` fixture that is used whenever a model
name is needed by other fixtures (e.g. `specific_config`) but
the model shouldn't actually matter
+ idea is this model should work no matter where tests are run,
CI v. locally
+ this is a code smell to me -- if tests don't depend on model
then why do I need a "dummy model"
+ but not obvious to me right now how to disentangle them, and I
just want to get the damn CI working
CI:
- have ci.yml download just test data generated for ci
- have ci run pytest using command-line option models,
and specifying only teenytweetynet for now
(default but make it explicit anyway)
- fix the `fix_prep_csv_paths` script so that it correctly
finds prep csv files with the new test data directory
names and structure
other refactoring
- move src/scripts to tests/scripts
- rename test_data to data_for_tests
+ so it doesn't look like a sub-package of tests to `pytest`
NickleDave
force-pushed
the
use-teenytweetynet-in-tests
branch
2 times, most recently
from
e2849e2
to
b7bddc5
Compare
|
Going ahead and merging this even though not all runs are passing (but some are, yay!) I believe this is do to an issue with running out of disk space, because it only happens to the I tried one of the workarounds (using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generating test data:
refactoring tests:
modelparameters to fixtures:specific_configfixturespecific_config_tomlfixturedataframefixturesprevious_run_pathfixture toprevious_run_path_factorymodelas argument to_previous_run_pathfunctionreturned by factory
modelscommand-line option for pytestmodelsfixturewith whatever arguments are passed in at command line
modelfixture in testsmodelfixture in a test in test_labeled_timebinsprevious_run_path_factorywithmodelintest_cli/test_learncurve.py
CI:
and specifying only teenytweetynet for now
(default but make it explicit anyway)
other refactoring
pytest