Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support costFromWeight envelopeType #21

Merged
merged 1 commit into from
Apr 19, 2021
Merged

support costFromWeight envelopeType #21

merged 1 commit into from
Apr 19, 2021

Conversation

jordipainan
Copy link
Member

No description provided.

brickpop
brickpop reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@brickpop brickpop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I think we should add this flag to the TS tests as well
  • If we want to restrict this flag to EVM processes only, then the contract is missing such check.
    • Do we really need to enforce this within the contract?
    • Can't we need this flag on non-EVM processes, in the future?

@jordipainan
Copy link
Member Author 

* [ ]  I think we should add this flag to the TS tests as well

* [ ]  If we want to restrict this flag to EVM processes only, then the contract is missing such check.
  
  * Do we really need to enforce this within the contract?
  * Can't we need this flag on non-EVM processes, in the future?

Adding the test.
After internal discussion we do not want to restrict the flag to EVM processes

@jordipainan jordipainan force-pushed the feature/costFromWeight branch 2 times, most recently from a245429 to d5d33c6 Compare April 14, 2021 12:27
@jordipainan
Copy link
Member Author

Added more tests on test/wrappers/envelope-type :) @brickpop

@brickpop
Copy link
Contributor

@jordipainan Looks good to me 👍

@jordipainan jordipainan merged commit 93275d0 into main Apr 19, 2021
@jordipainan jordipainan deleted the feature/costFromWeight branch May 6, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordipainan @brickpop