Skip to content
This repository has been archived by the owner on Aug 23, 2024. It is now read-only.

F/upgrade to react 18 #67

Merged
merged 14 commits into from
Mar 13, 2023
Merged

F/upgrade to react 18 #67

merged 14 commits into from
Mar 13, 2023

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Feb 24, 2023

Breaking changes

  • Use React 18
  • Use Next 13 : this mean faster build using SWC instead of babel
  • Deprecate rainbow-react-components in favour of chakra-ui. Chakra-ui is used on the vocdoni ui-components, and need React 18. On the other hand, the rainbow components doesn't support React 18.
  • Fixed multiple React hydratation errors, caused by invalid dom nesting components
  • Yarn is tested and supported 100%

@selankon selankon force-pushed the f/upgrade_to_react_18 branch 2 times, most recently from 52efbbf to 35b7f11 Compare February 24, 2023 10:17
package.json Outdated Show resolved Hide resolved
@selankon selankon force-pushed the f/upgrade_to_react_18 branch 2 times, most recently from 2961e14 to 12aba3b Compare March 1, 2023 10:00
components/blocks/list-items.tsx Outdated Show resolved Hide resolved
@selankon selankon marked this pull request as ready for review March 1, 2023 10:09
@selankon
Copy link
Collaborator Author

selankon commented Mar 1, 2023

The only remaining thing to get this merged is to update the @vocdoni/react-hooks peer dependency from React 17 to react 17 | 18.

@selankon selankon force-pushed the f/upgrade_to_react_18 branch 2 times, most recently from bfcd415 to 2452b1f Compare March 1, 2023 10:57
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor indentation issue, but other than that LGTM

components/elements/date-picker.tsx Show resolved Hide resolved
@selankon selankon force-pushed the f/upgrade_to_react_18 branch 4 times, most recently from d8c17aa to aa17cf5 Compare March 7, 2023 11:13
@selankon selankon merged commit c5d6124 into master Mar 13, 2023
@selankon selankon deleted the f/upgrade_to_react_18 branch March 13, 2023 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants