This repository has been archived by the owner on Aug 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selankon
force-pushed
the
f/upgrade_to_react_18
branch
2 times, most recently
from
February 24, 2023 10:17
52efbbf
to
35b7f11
Compare
elboletaire
suggested changes
Feb 27, 2023
selankon
force-pushed
the
f/upgrade_to_react_18
branch
2 times, most recently
from
March 1, 2023 10:00
2961e14
to
12aba3b
Compare
elboletaire
suggested changes
Mar 1, 2023
The only remaining thing to get this merged is to update the |
selankon
force-pushed
the
f/upgrade_to_react_18
branch
2 times, most recently
from
March 1, 2023 10:57
bfcd415
to
2452b1f
Compare
elboletaire
suggested changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor indentation issue, but other than that LGTM
selankon
force-pushed
the
f/upgrade_to_react_18
branch
4 times, most recently
from
March 7, 2023 11:13
d8c17aa
to
aa17cf5
Compare
elboletaire
approved these changes
Mar 10, 2023
From version 12 Link component doesn't need an <a> tag
selankon
force-pushed
the
f/upgrade_to_react_18
branch
from
March 13, 2023 07:43
aa17cf5
to
e55b18c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
React 18
Next 13
: this mean faster build using SWC instead of babelrainbow-react-components
in favour ofchakra-ui
. Chakra-ui is used on the vocdoni ui-components, and need React 18. On the other hand, the rainbow components doesn't support React 18.hydratation errors
, caused by invalid dom nesting components