Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent notify both failure and success #94

Closed
wants to merge 1 commit into from
Closed

Prevent notify both failure and success #94

wants to merge 1 commit into from

Conversation

quanlt
Copy link

@quanlt quanlt commented Aug 28, 2018 •
edited
Loading

onSuccess was called right after onFailure when you don't have an internet connection, or the downloading task was failed.
it also fixe_s #72

@voghDev
Copy link
Owner

voghDev commented Aug 28, 2018 •
edited
Loading

So true. Didn't notice I already had the same code that you provide in the PR included in my codebase. Haven't released it yet.

Will upload a version ASAP with this fix. Thanks for your PR :)

@quanlt quanlt closed this Aug 29, 2018
@quanlt quanlt deleted the develop branch August 29, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quanlt @voghDev