[Merged by Bors] - fix: update BlockTemplate types to use diagramID instead of new structure (CT-679) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viniciusdacal
force-pushed
the
vinicius/add-block-template-types/CT-679
branch
from
0892b8d
to
263965e
Compare
JoshTheDeveloper
approved these changes
Aug 9, 2022
z4o4z
reviewed
Aug 9, 2022
| @@ -1,7 +1,5 @@ | |||
| import { BaseDiagramNode } from '../base'; | |||
|
|
|||
| export interface BlockTemplate { | |||
There was a problem hiding this comment.
why do we need BlockTemplate type?
viniciusdacal
force-pushed
the
vinicius/add-block-template-types/CT-679
branch
from
263965e
to
22a01bb
Compare
z4o4z
approved these changes
Aug 9, 2022
| @@ -0,0 +1,5 @@ | |||
| export interface CanvasTemplate { | |||
There was a problem hiding this comment.
Can we add an id field so for the endpoints we can select by id instead of name?
viniciusdacal
force-pushed
the
vinicius/add-block-template-types/CT-679
branch
from
22a01bb
to
defe33d
Compare
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
…ture (CT-679) (#346) <!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements CT-679** ### Brief description. What is this change? <!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->
|
Kudos, SonarCloud Quality Gate passed!
|
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements CT-679
Brief description. What is this change?
Implementation details. How do you make this change?
We decided to use diagram to save the templates. That will better support migrations and it will makes things easier if we decide to support edition of a template.
To support that, we introduced a new diagram type: TEMPLATE.
Also, version will only point out to a diagramID instead of saving the whole node inside it.